Re: [PATCH 2/8] wildmatch: rename constants and update prototype

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 26, 2012, 18:44 UTC
Message-ID: <7vvcboodpg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1356163028-29967-3-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 6 quoted lines

> @@ -134,101 +131,102 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case)
>  				p_ch = NEGATE_CLASS;
>  #endif
>  			/* Assign literal TRUE/FALSE because of "matched" comparison. */
> -			special = p_ch == NEGATE_CLASS? TRUE : FALSE;
> +			special = p_ch == NEGATE_CLASS;

Leftover comment needs to be reworded as well???

>  			if (special) {
>  				/* Inverted character class. */
>  				p_ch = *++p;
>  			}

I'd prefer "special" used in the "case '['" given a more sensible name here.