Re: [PATCH 04/19] reset: don't allow "git reset -- $pathspec" in bare repo
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 10, 2013, 18:04 UTC
- Message-ID
- <7vvcb429um.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CANiSa6gK+RqovV+NKWgV57hz-p_O085HN7WCg9qvQAD-Ynpfjw@mail.gmail.com>
Martin von Zweigbergk <martinvonz@gmail.com> writes:
> ... Fix by moving > the branching point after the check.
OK, that is what I missed. We have an existing check for mixed reset, which was originally meant to handle case without any pathspec but can use the same error condition (i.e. type is mixed and repository is bare) and error message (i.e. no mixed reset in a bare repository). "reset with pathspec" was done before that check kicked in.
Thanks for clarification (and sorry for the noise).