Re: [PATCH] Makefile: promote wildmatch to be the default fnmatch implementation

From: Junio C Hamano <gitster@pobox.com>
Date: May 30, 2013, 02:25 UTC
Message-ID: <7vvc61p5jw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1369877684-5050-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 6 quoted lines

> This makes git use wildmatch by default for all fnmatch() calls. Users
> who want to use system fnmatch (or compat fnmatch) need to set
> NO_WILDMATCH flag.
>
> wildmatch is a drop-in fnmatch replacement with more features. Using
> wildmatch gives us a consistent behavior across platforms.

Hmph, could you (no need to hurry, though) check the previous discussion and point at what we decided if we did reach any conclusion to refresh our collective memory?

While I agree this is a good move in the longer term in that we get the often-asked-for "foo/**/*.c" match and also we have one less platform differences to worry about, I somehow have a recollection that we discussed that there are incompatibilities in dark corners we would want to warn users about and lay a transition plan across some major version bump.

Thanks.