git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] t4211: demonstrate empty -L range crash

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 23, 2013, 19:03 UTC
Message-ID
<7vvc416qvq.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130723175942.GA21019@goldbirke>
SZEDER Gábor <szeder@ira.uka.de> writes:
> You could avoid the 'cat' here and patch in 4/5 by doing $(wc -l <b.c).
Correct.
> (Side question: the test suite is full with similar constructs, i.e.
> redirecting file contents to stdin, but why not just use wc -l b.c,
> i.e. let wc open the file?)

"wc -l <b.c" is the correct form for the purpose of these tests; otherwise you will see the filename in the output, and you need to somehow strip it if you are only interested in the line count.

Previous: SZEDER GáborNext: SZEDER Gábor
Message 5 of 17 in “range-set and line-log bug fixes”
  1. 0/5 range-set and line-log bug fixesEric Sunshine, Jul 23, 2013
  2. 1/5 range-set: fix sort_and_merge_range_set() corner case bugEric Sunshine, Jul 23, 2013
  3. 2/5 t4211: demonstrate empty -L range crashEric Sunshine, Jul 23, 2013
  4. SZEDER GáborJul 23, 2013
  5. Junio C HamanoJul 23, 2013
  6. SZEDER GáborJul 23, 2013
  7. Eric SunshineJul 23, 2013
  8. Junio C HamanoJul 24, 2013
  9. Eric SunshineJul 24, 2013
  10. 3/5 range-set: satisfy non-empty ranges invariantEric Sunshine, Jul 23, 2013
  11. 4/5 t4211: demonstrate crash when first -L encountered is empty rangeEric Sunshine, Jul 23, 2013
  12. 5/5 line-log: fix "log -LN" crash when N is last line of fileEric Sunshine, Jul 23, 2013
  13. Thomas RastJul 23, 2013
  14. Eric SunshineJul 25, 2013
  15. Eric SunshineJul 25, 2013
  16. Johannes SixtJul 25, 2013
  17. Eric SunshineJul 25, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.