git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Do not include unused header files.

From
Junio C Hamano <junkio@cox.net>
Date
May 28, 2005, 09:55 UTC
Message-ID
<7vu0knwu7v.fsf@assigned-by-dhcp.cox.net>

Some source files were including "delta.h" without actually needing it. Remove them.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

count-delta.c | 1 - diffcore-pathspec.c | 1 - diffcore-pickaxe.c | 1 - 3 files changed, 3 deletions(-)

diff --git a/count-delta.c b/count-delta.c
--- a/count-delta.c
+++ b/count-delta.c
@@ -6,7 +6,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <limits.h>
-#include "delta.h"
 #include "count-delta.h"
 
 static unsigned long get_hdr_size(const unsigned char **datap)
diff --git a/diffcore-pathspec.c b/diffcore-pathspec.c
--- a/diffcore-pathspec.c
+++ b/diffcore-pathspec.c
@@ -4,7 +4,6 @@
 #include "cache.h"
 #include "diff.h"
 #include "diffcore.h"
-#include "delta.h"
 
 struct path_spec {
 	const char *spec;
diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c
--- a/diffcore-pickaxe.c
+++ b/diffcore-pickaxe.c
@@ -4,7 +4,6 @@
 #include "cache.h"
 #include "diff.h"
 #include "diffcore.h"
-#include "delta.h"
 
 static int contains(struct diff_filespec *one,
 		    const char *needle, unsigned long len)
------------------------------------------------
Message 1 of 1 in “Do not include unused header files.”
  1. Do not include unused header files.Junio C Hamano, May 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.