Re: Sanity check of git-commit patch, was Re: [PATCH] Making CFLAGS compilant with GNU Coding Standards
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 9, 2005, 12:53 UTC
- Message-ID
- <7vu0hzw9sx.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0508091212170.6752@wgmdd8.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> I just checked. Three nitpicks: > > - I don't like the GNU way to abbreviate long options too much...
True. My bad old habit.
> - Multiple -m options was actually a feature of my version of the patch.
Ah, OK.
> - The "case .. in x) .. ;; esac;" construct is sometimes more confusing > than a simple "if", or even a "[ .. = x ] && ..".
Yes sometimes.