Re: git-core-arch: Missing dependency

From: Junio C Hamano <junkio@cox.net>
Date: Nov 11, 2005, 18:51 UTC
Message-ID: <7vu0ejm30l.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <4374E0EF.2020801@op5.se>

Andreas Ericsson <ae@op5.se> writes:

Show 12 quoted lines

> Junio C Hamano wrote:
>> Horst von Brand <vonbrand@inf.utfsm.cl> writes:
>>
>>>The command git-archimport makes use of tla, but the relevant package(s) are
>>>not on the requirements
>> Thanks.  Should the fix be like this?
>>  Group:          Development/Tools
>> -Requires:       git-core = %{version}-%{release}
>> +Requires:       git-core = %{version}-%{release}, tla
>
> Just to be anal;
> Requires doesn't usually include the %release,...

Obviously both you and Chris (who did the part you are quoting for us) know RPM spec a lot better than I do, and I see two experts contradicting with each other. It could have been just an oversight, or it might have done deliberately --- I cannot judge myself, so I punt here. I'll remove "-%{release}" when I hear Chris says he agrees with you.

Thanks both.