Re: Fix silly typo in new builtin grep

From: Junio C Hamano <junkio@cox.net>
Date: May 16, 2006, 03:18 UTC
Message-ID: <7vu07qfyj0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0605151743360.3866@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

> The "-F" flag apparently got mis-translated due to some over-eager 
> copy-paste work into a duplicate "-H" when using the external grep.

Thanks. I've pushed it out to "master", along with some other stuff.

Show 12 quoted lines

> Me likee the new built-in grep. The ability to say
>
> 	git grep __make_request v2.6.13 -- '*.c'
>
> to grep for it in a specific version is well worth the fact that it 
> obviously ends up being slower than grepping in the currently checked-out 
> tree. It's doing a hell of a lot more, but despite that it's not at all 
> that slow.
>
> (In fact, I would say that doing the above command in just 4 seconds is 
> damn impressive - it's a large code-base, and v2.6.13 is several months, 
> and over 20 _thousand_ revisions ago).

That is a BS praise and you know it ;-). You do not have delta chains that are 20k long, so grepping from the tree 10 revs ago and from the tree 20k revs ago would not make a difference.

It _would_ be impressive to CVS folks, but even there each path would not have 20k revisions. The kernel patches tend to touch 3 paths per patch on average, so 60k changes over 18k files distributed unevenly -- my guess (I could count but haven't) is probably 200 revisions at most for most frequently touched file.