git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Stop making git-merge-recur

From
Junio C Hamano <junkio@cox.net>
Date
Oct 2, 2006, 04:41 UTC
Message-ID
<7vu02nz5w6.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<45207D32.8040300@gmail.com>
A Large Angry SCM <gitzilla@gmail.com> writes:
> Git-merge-recur is no longer installed and make clean no longer
> removes it, so creating making it.
Thanks for noticing.

The bug is actually not installing nor cleaning it. People who wanted to stay on the bleeding edge could add "-s recur" on the command line, or have "merge.twohead = recur" in the config; this is what we actually encouraged people for wider testing. We do not suddenly break them. I planned the removal for the release after 1.4.3.

This should fix it -- could you eyeball it please?
-- >8 --
Makefile: install and clean merge-recur, still.

We advertised git-merge-recur for some time, and we planned to support it for one release after we made it the 'recursive'. However we forgot to install it nor have "make clean" clean it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
diff --git a/Makefile b/Makefile
index dd33158..401b893 100644
--- a/Makefile
+++ b/Makefile
@@ -215,7 +215,8 @@ BUILT_INS = \
 	$(patsubst builtin-%.o,git-%$X,$(BUILTIN_OBJS))
 
 # what 'all' will build and 'install' will install, in gitexecdir
-ALL_PROGRAMS = $(PROGRAMS) $(SIMPLE_PROGRAMS) $(SCRIPTS)
+ALL_PROGRAMS = $(PROGRAMS) $(SIMPLE_PROGRAMS) $(SCRIPTS) \
+	git-merge-recur$X
 
 # Backward compatibility -- to be removed after 1.0
 PROGRAMS += git-ssh-pull$X git-ssh-push$X
@@ -586,8 +587,7 @@ export prefix TAR INSTALL DESTDIR SHELL_
 
 ### Build rules
 
-all: $(ALL_PROGRAMS) $(BUILT_INS) git$X gitk gitweb/gitweb.cgi \
-	git-merge-recur$X
+all: $(ALL_PROGRAMS) $(BUILT_INS) git$X gitk gitweb/gitweb.cgi
 
 all: perl/Makefile
 	$(MAKE) -C perl
Previous: A Large Angry SCMNext: A Large Angry SCM
Message 3 of 4 in “Stop making git-merge-recur”
  1. Stop making git-merge-recurA Large Angry SCM, Oct 2, 2006
  2. A Large Angry SCMOct 2, 2006
  3. Junio C HamanoOct 2, 2006
  4. A Large Angry SCMOct 2, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.