Re: git-bisect feature suggestion: "git-bisect diff"

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 7, 2007, 21:44 UTC
Message-ID: <7vtzmuyyc3.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071207213541.GA11723@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> On Fri, Dec 07, 2007 at 04:34:14PM -0500, Jeff King wrote:
>
>> On Fri, Dec 07, 2007 at 02:25:34AM -0800, Junio C Hamano wrote:
>> 
>> > git-bisect visualize: work in non-windowed environments better
>> 
>> Isn't this more or less the use case for the "git view" alias?
>
> Which isn't to say that I don't think your solution is nicer; it is. But
> if we don't use it here, then perhaps "git view" really is a solution in
> search of a problem.

Well, I think "git view" should not be just "predefined alias that the user can override wholesale", which is what you currently have. I think it can just be an example in "git config" manpage (i.e. "If you want to, you can alias 'view' to 'gitk' or 'gitview'") and I do not think we need core-side support for that.

If it becomes cleverer, that's a different story. Noticing if the user is in windowing environment or not, and acting differently, would make it a single command that acts sensibly and in context sensitive way.