git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] avoid trailing whitespace in zero-change diffstat lines

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 14, 2008, 07:22 UTC
Message-ID
<7vtzfwh45d.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080614065614.GC9006@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
> In some cases, we produce a diffstat line even though no lines have
> changed (e.g., because of an exact rename). In this case, there is no
> +/- "graph" after the number of changed lines. However, we output the
> space separator unconditionally, meaning that these lines contained a
> trailing space character.
>
> This isn't a huge problem, but in cleaning up the output we are able to
> eliminate some trailing whitespace from a test vector.

This is why I love your patches. Not merely fixing superficial issues but doing so with _real thinking_ ;-)

Previous: Jeff KingNext: Jeff King
Message 17 of 19 in “t/.gitattributes: only ignore whitespace errors in test files”
  1. t/.gitattributes: only ignore whitespace errors in test filesLea Wiemann, Jun 12, 2008
  2. Jeff KingJun 13, 2008
  3. t/.gitattributes: only ignore whitespace errors in test filesLea Wiemann, Jun 13, 2008
  4. Junio C HamanoJun 13, 2008
  5. Jeff KingJun 14, 2008
  6. 1/4 fix whitespace violations in test scriptsJeff King, Jun 14, 2008
  7. Jeff KingJun 14, 2008
  8. Junio C HamanoJun 14, 2008
  9. Jeff KingJun 14, 2008
  10. 1/5 fix whitespace violations in test scriptsJeff King, Jun 14, 2008
  11. 2/5 mask necessary whitespace policy violations in test scriptsJeff King, Jun 14, 2008
  12. 3/5 avoid whitespace on empty line in automatic usage messageJeff King, Jun 14, 2008
  13. 4/5 avoid trailing whitespace in zero-change diffstat linesJeff King, Jun 14, 2008
  14. 5/5 enable whitespace checking of test scriptsJeff King, Jun 14, 2008
  15. 2/4 mask necessary whitespace policy violations in test scriptsJeff King, Jun 14, 2008
  16. 3/4 avoid trailing whitespace in zero-change diffstat linesJeff King, Jun 14, 2008
  17. Junio C HamanoJun 14, 2008
  18. Jeff KingJun 14, 2008
  19. 4/4 enable whitespace checking of test scriptsJeff King, Jun 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.