Re: [PATCH] Note the use of "rebase -i" to squash consecutive commits into one.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 19, 2008, 03:32 UTC
- Message-ID
- <7vtzdhisre.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1219012340-23376-1-git-send-email-offby1@blarg.net>
This is missing sign-off.
More importantly, I do not think adding an extra illustration that starts talking about an example history that is _different_ from what was being discussed is a good idea. The end result lacks coherence and forces the reader to reset his mind for each example.
I'd suggest you to rewrite the example part that begins a few lines before you touched. Present the example "original" history with illustration first (and call it A---B---C---D---E---F---G, not QRSTU), and clarify the existing example of reordering the last 5 commits, and show the history after such reordering.
Then you talk about squashing, with before-and-after illustrations, but base that illustration on the same example history. That way, the reader has to understand the original scene only once to grok both examples.