Re: [PATCH] "git diff <tree>{3,}": do not reverse order of arguments

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 11, 2008, 21:36 UTC
Message-ID: <7vtzbiizk8.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <237967ef0810110553r662df370ud1ec34de402bfe1c@mail.gmail.com>

"Mikael Magnusson" <mikachu@gmail.com> writes:

Show 8 quoted lines

> 2008/10/11 Junio C Hamano <gitster@pobox.com>:
>> Perhaps the thinko was caused by discrepancy between the way internal
>> revision parser handles A..B and the way git-rev-parse parses it.  While
>> the internal revision parser parses it into "A ^B", rev-parse gives them
>> in reverse order, i.e. "B ^A" (which is not going to change).  In any
>> case, thanks for spotting this.
>
> Ehm, do you mean the internal parses it into "A ^B" and rev-parse gives "^B A"?

Sorry; a typo is in my description on the result from the internal parser.

For A..B, rev-parse gives B^ then A, and internal gives ^A in ent[0] and B in ent[1].