Re: [PATCH next resend] bash completion: refactor diff options

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 18, 2009, 07:18 UTC
Message-ID: <7vtz7xytdo.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1232240603-11729-1-git-send-email-trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

Show 9 quoted lines

> diff, log and show all take the same diff options.  Refactor them from
> __git_diff and __git_log into a variable, and complete them in
> __git_show too.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
>
> ---
>
> Any news on this?

Show 6 quoted lines

> +__git_diff_common_options="--stat --numstat --shortstat --summary
>  			--patch-with-stat --name-only --name-status --color
>  			--no-color --color-words --no-renames --check
>  			--full-index --binary --abbrev --diff-filter=
> -			--find-copies-harder --pickaxe-all --pickaxe-regex
> +			--find-copies-harder

The changes around pickaxe made me "Huh?". For log pickaxe makes very good sense but for a single diff it doesn't, yet the original seems to have had them only on "git diff" and not on "git log", which feels wrong.

Other than that, I think the patch tries to achieve a great thing in the longer term---we do not have to worry about common parts going out of sync between diff and log family of commands.