Re: [PATCHv5 1/3] gitweb: support to globally disable a snapshot format

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 6, 2009, 06:20 UTC
Message-ID: <7vtz0lpinr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <35210404-7E4C-4CB9-881C-45C9E61ACECE@uwaterloo.ca>

Mark A Rada <marada@uwaterloo.ca> writes:

Show 8 quoted lines

> Re-ordered, as suggested by Junio.
>
> --
> Mark A Rada (ferrous26)
> marada@uwaterloo.ca
>
>
> --->8---

Please have all of the above after the "---" line.

> From: Mark Rada <marada@uwaterloo.ca>
> Date: Wed, 5 Aug 2009 21:02:54 -0400
> Subject: [PATCH 1/3] gitweb: support to globally disable a snapshot
> format

And you do not need these four lines, as they match what you have in the e-mail header.

> I added an optional variable, 'disabled', to to the
> $known_snapshot_formats keys so that a Gitweb administrator can
> globally enable or disable a specific format for snapshots.

"to to"?

We tend not to say "I did this and that" in our log messsages; order the codebase to do certain new things, or order the maintainer to change the code to make it do new things. e.g.

	Allow gitweb administrators to set in %known_snapshot_formats hash
	an optional key, 'disabled' for specific format.  This can be used
	to configure out individual formats.

> All formats are enabled by default because project specific overriding
> is disabled by default.

That is not quite a good justification; but "all the formats have been enabled so far, and installing an updated gitweb should not change the existing behaviour" is.