Re: [RFC PATCH v5 0/3] git-remote-fd & git-remote-ext

Every time I queued this series, I've been fixing up styles without complaining. It is boring and in general not very fun to spend time fixing style violations, and the worst part of the story is that by the time I am done, I don't have time left for addressing issues in the substance of the patch or energy and concentration required for handling patches from other people.

I think I probably should have complained earlier. I am assuming that you are rewriting and rebasing, so once they are fixed at your end, I will hopefully have to re-fix everything over and over again in the future round.

Could you fix these up at your end please?

ERROR: space required before the open parenthesis '('
#216: FILE: transport-helper.c:990:
+	while(t->state != SSTATE_FINISHED) {

ERROR: "foo* bar" should be "foo *bar"
#596: FILE: builtin/remote-fd.c:58:
+	char* end;

ERROR: spaces required around that '!=' (ctx:WxV)
#603: FILE: builtin/remote-fd.c:65:
+	if ((end == argv[2]) || (*end != ',' && *end !='/' && *end))
 	                                             ^

ERROR: "foo* bar" should be "foo *bar"
#609: FILE: builtin/remote-fd.c:71:
+		char* end2;

ERROR: spaces required around that '!=' (ctx:WxV)
#612: FILE: builtin/remote-fd.c:74:
+		if ((end2 == end + 1) || (*end2 !='/' && *end2))
 		                                ^

ERROR: do not initialise globals to 0 or NULL
#897: FILE: builtin/remote-ext.c:24:
+char* git_req = NULL;

ERROR: "foo* bar" should be "foo *bar"
#897: FILE: builtin/remote-ext.c:24:
+char* git_req = NULL;

ERROR: do not initialise globals to 0 or NULL
#898: FILE: builtin/remote-ext.c:25:
+char* git_req_vhost = NULL;

ERROR: "foo* bar" should be "foo *bar"
#898: FILE: builtin/remote-ext.c:25:
+char* git_req_vhost = NULL;

ERROR: space required before the open parenthesis '('
#959: FILE: builtin/remote-ext.c:86:
+			switch(str[rpos]) {

ERROR: space required before the open parenthesis '('
#973: FILE: builtin/remote-ext.c:100:
+			switch(str[rpos]) {

ERROR: space required before the open parenthesis '('
#983: FILE: builtin/remote-ext.c:110:
+	switch(special) {

ERROR: "foo** bar" should be "foo **bar"
#1002: FILE: builtin/remote-ext.c:129:
+	char** ret;

ERROR: "foo* bar" should be "foo *bar"
#1006: FILE: builtin/remote-ext.c:133:
+		char* ret;

ERROR: "(foo*)" should be "(foo *)"
#1014: FILE: builtin/remote-ext.c:141:
+	ret = xcalloc(arguments + 1, sizeof(char*));

ERROR: "(foo**)" should be "(foo **)"
#1018: FILE: builtin/remote-ext.c:145:
+	return (const char**)ret;

ERROR: "foo* bar" should be "foo *bar"
#1026: FILE: builtin/remote-ext.c:153:
+	char* buffer;

total: 17 errors, 0 warnings, 851 lines checked