git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 11/14] t3032-*.sh: Pass the -b (--binary) option to sed on cygwin

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 14, 2010, 19:24 UTC
Message-ID
<7vtyigtaxn.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4D07B8B5.2030409@ramsay1.demon.co.uk>
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
Show 13 quoted lines
> The test using the conflict_hunks helper function (test 9) fails
> on cygwin, since sed (by default) throws away the CR from CRLF
> line endings. This behaviour is undesirable, since the validation
> code expects the CRLF line-ending to be present. In order to fix
> the problem we pass the -b (--binary) option to sed, using the
> SED_OPTIONS variable. We use the SED_STRIPS_CR prerequisite in the
> conditional initialisation of SED_OPTIONS.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Note that this test does not fail on MinGW, but I don't
> really know why, given commit ca02ad3... ahem ;-)
Ahem, indeed.  Why?
Previous: Ramsay JonesNext: Eric Sunshine
Message 2 of 8 in “t3032-*.sh: Pass the -b (--binary) option to sed on cygwin”
  1. 11/14 t3032-*.sh: Pass the -b (--binary) option to sed on cygwinRamsay Jones, Dec 14, 2010
  2. Junio C HamanoDec 14, 2010
  3. Eric SunshineDec 14, 2010
  4. Johannes SixtDec 15, 2010
  5. Eric SunshineDec 15, 2010
  6. Ramsay JonesDec 16, 2010
  7. Johannes SixtDec 17, 2010
  8. Ramsay JonesDec 18, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.