Re: obstack fails to compile on OS X 10.7

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 29, 2011, 06:07 UTC
Message-ID: <7vty907nud.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110829031806.GA58338@gmail.com>

David Aguilar <davvid@gmail.com> writes:

Show 5 quoted lines

>> -void obstack_free (struct obstack *__obstack, void *__block);
>> +void obstack_free (struct obstack *obstack, void *block);
>
> Tiny nit: I know it's just a declaration but would it be advisable to
> drop the variable names altogether here?

I agree. In general it is easier to read if parameter names to a function declaration is omitted, especially if it is clear from their types what they mean [*1*]. And in this case, it is.

> Tested-by: David Aguilar <davvid@gmail.com>

Thanks.

[Footnote]

*1* It is Ok to spell them out in a case like this:

    int copy(char *dst, const char *src, size_t);

You do not have to, as "char *" vs "const char *" makes it clear which one is which.