git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Gitweb: Avoid warnings when a repo does not have a valid HEAD

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 15, 2011, 22:28 UTC
Message-ID
<7vty51lbb0.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7v62hhmr2s.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Joe Ratterman <jratt0@gmail.com> writes:
>
>> It is possible that the HEAD reference does not point to an existing
>> branch.  When viewing such a repository in gitweb, a message like this
>> one was sent to the error log:
>>
>>   gitweb.cgi: Use of uninitialized value in string eq at /usr/src/git/gitweb/gitweb.cgi line 5115.
>>
> ..., but in that case a repository with
> a HEAD that points at an unborn branch _and_ have other refs that do point
> at existing commit is already screwed-up, so if we want to be extremely
> pedantic then perhaps ...
>
>     my $curr = ((defined $head && exists $ref{"id"} && defined $ref{"id"})
> 		? ($ref{"id"} eq $head)
>                 : 0);

Just in case, I was not suggesting to update the patch to look like the above by "if we want to be extremely pedantic".

After all, that error message in the log may be a good thing that notifies the site administrators about a suspicious repository so that it can be fixed (even though it was not a designed "feature" but something that happens to work).

Previous: Junio C HamanoNext: Jakub Narebski
Message 3 of 4 in “Gitweb: Avoid warnings when a repo does not have a valid HEAD”
  1. Gitweb: Avoid warnings when a repo does not have a valid HEADJoe Ratterman, Dec 15, 2011
  2. Junio C HamanoDec 15, 2011
  3. Junio C HamanoDec 15, 2011
  4. Jakub NarebskiDec 16, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.