Re: [PATCH] clone: fix progress-regression

From: Junio C Hamano <gitster@pobox.com>
Date: May 7, 2012, 19:47 UTC
Message-ID: <7vtxzr4vua.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1336418593-2792-1-git-send-email-kusmabite@gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

Show 9 quoted lines

> In 5bd631b3 ("clone: support multiple levels of verbosity"), the
> default behavior to show progress of the implicit checkout in
> the clone-command regressed so that progress was only shown if
> the verbose-option was specified.
>
> Fix this by making option_verbosity == 0 output progress as well.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---

Thanks.

Show 5 quoted lines

> Hmpf. While tidying this up for a proper submission, I found out that
> writing a reliable test is tricky due to the start_progress_delay-usage.
> I'd have to clone a repo that does not progress more than 50% of the
> checkout-operation within one second or something like that (I didn't
> quite follow the logic there), which is a lot :P.

In real life, most of the checkout is fairly quick for even projects like the kernel, and the logic is an attempt to avoid cluttering the terminal with progress unless it takes unusually long and might make the user feel worried.

> So perhaps writing a test to avoid similar breakages in the future isn't
> worth it?

I agree that it probably isn't worth it, given that it took forever for anybody to even complain about this.