Re: [RFC] Deal with HTTP 401 by requesting credentials.

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 1, 2012, 17:01 UTC
Message-ID: <7vtxyv2cft.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120601083537.GA32340@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Thu, May 31, 2012 at 05:24:55PM -0500, Kevin Stange wrote:
>
>> Request credentials from the user if none are already defined when a
>> HTTP 401 is received on a restricted repository.  Then, resubmit the
>> request and return the final result.
>> 
>> This allows all webdav transactions to obtain credentials without having
>> to individually handle the case in each request.  Having push working
>> with HTTP auth is needed for a use case I have where storing the
>> credentials in .netrc or using SSH keys is inappropriate.
>
> We already do this at a higher level in http_request, which in turns
> calls into finish_active_slot. So if we were going to go this route,
> wouldn't we also want to remove the 401 handling in http_request?

Wouldn't the higher levels know a lot more about the context this request was made, though? What problem does the patch try to solve? Some higher level callers missing the "if we got 401, then reset and retry" logic? Wouldn't it be saner to fix the breakage there?

> The dumb-http push code is the only thing that does not go through
> http_request these days. So another option would be to refactor it to go
> through that central point.

It does sound like the right approach to take.

Thanks.