Re: [PATCH/RFC] blame: respect "core.ignorecase"

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 10, 2012, 21:38 UTC
Message-ID: <7vtxv5lfsv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120910203442.GA968@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 19 quoted lines

> On Mon, Sep 10, 2012 at 01:30:03PM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > If the proposal were instead to add a certain type of pathspec that is
>> > case-insensitive[2], that would make much more sense to me. It is not
>> > violating git's case-sensitivity because it is purely a _query_ issue.
>> > And it is a feature you might use whether or not your filesystem is case
>> > sensitive.
>> > ...
>> > [2] I did not keep up with Duy's work on pathspec magic-prefixes (and I
>> >     could not find anything relevant in the code or documentation), but
>> >     it seems like this would be a logical feature to support there.
>> 
>> I think it mostly is in setup.c (look for "Magic pathspec").
>
> Thanks, that helped. I got excited when I saw the "icase" in the
> comments and thought it might already be implemented. But it looks like
> it is still to be done. :)

Yeah, some are tongue-in-cheek (e.g. I do not know what "recursive pathspec" even means), but "noglob" probably is an urgent need from correctness point of view for people who are writing Porcelain and want to interact with a history that records funny filenames. Currently you can "git <cmd> 'foo\*'" to match a path that is exactly 'foo*' (because it matches) but you also have to hope there is no other paths that happens to match that pattern. A script that grabs paths out of ls-files output and then tries to use them as pathspec would want to have a way to say "This is literal. Do not honor globs in it".