Re: [PATCH] mergetool--lib: refactor {diff,merge}_cmd logic

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 17, 2013, 20:13 UTC
Message-ID: <7vtxkwbin7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAJDDKr5ewcYgtZn-oCQ5b=rGix5EALRdiSaNMatOwtP75e0h3g@mail.gmail.com>

David Aguilar <davvid@gmail.com> writes:

Show 11 quoted lines

> On Sun, Jun 16, 2013 at 10:51 AM, John Keeping <john@keeping.me.uk> wrote:
>> Instead of needing a wrapper to call the diff/merge command, simply
>> provide the diff_cmd and merge_cmd functions for user-specified tools in
>> the same way as we do for built-in tools.
>>
>> Signed-off-by: John Keeping <john@keeping.me.uk>
>> ---
>
> This is a nice cleanup.
>
> Acked-by: David Aguilar <davvid@gmail.com>

Thanks, both.