Re: Git bug. "make [all]" does not use USE_LIBPCRE when "configure --with-libpcre" was previously run

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2013, 16:39 UTC
Message-ID: <7vtxistefl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v38qcuudi.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

> This does not have anything to do with C, but is a breakage in our
> autoconf script.  It appears that anything that is meant to be
> appended at end via $config_appended_defs mechanism is missing from
> the end result.
>
> In fact, symbols whose explicit substitution the above patch
> removes, e.g. CC_LD_DYNPATH, TCLTK_PATH, NEEDS_SSL_WITH_CRYPTO,
> etc. are all missing.

Wait, I spoke too soon.

    $ rm -f configure config.status &&
      make configure &&
      ./configure --with-libpcre &&
      grep USE_LIBPCRE config.mak.autogen
    USE_LIBPCRE=YesPlease

no longer reproduces for me (even though I _thought_ I tried and saw the breakage). Hmmmmmm.....