Re: git-daemon: path validation, export all option

From: Junio C Hamano <junkio@cox.net>
Date: Sep 27, 2005, 04:19 UTC
Message-ID: <7vslvr6t1u.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <4338AACC.1050305@zytor.com>

"H. Peter Anvin" <hpa@zytor.com> writes:

Show 6 quoted lines

> A first attempt to make git-daemon a bit more suitable for kernel.org 
> use: it allows the user to specify a whitelist of directories, rejects 
> paths which have . or .. in them (to avoid bypassing the whitelist), and 
> allows for an --export-all option.
>
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>

I understand the motivation behind --export-all and directory whitelist and these changes look good. Thanks.

Show 7 quoted lines

> +	if ( ok_paths && *ok_paths ) {
> +		int ok = 0;
> +...
> +	}
> +
> +	return 1;		/* Path acceptable */
> +}

A microNit. You could lose 'int ok' and return 1 directly where you assign 1 to it and break.

> -	chdir(".git");

I am unsure about this removal of "minor convenience feature". Although I do not think git-daemon is widely used on the field, this change breaks existing setup if there is any.