Re: [PATCH] Makefile: use --unsafe option under Cygwin with asciidoc

From: Junio C Hamano <junkio@cox.net>
Date: May 2, 2007, 16:56 UTC
Message-ID: <7vslaf4121.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <46388CBE.1080605@byu.net>

Eric Blake <ebb9@byu.net> writes:

Show 8 quoted lines

> According to Jari Aalto on 5/2/2007 5:49 AM:
>> New: variable ASCIIDOC_FLAGS was introduced. It was also added to two
>> new targets. The old ASCIIDOC_EXTRA is set to --unsafe under Cygwin to
>> ignore asciidoc error about unsafe include.
>
> This isn't just for cygwin, since it benefits any platform where the
> installed asciidoc is 8.1 or better (asciidoc is currently at 8.2.1 if you
> build the from tarballs).

What unsafe things do we include? Maybe _that_ is what should be fixed?

Also the last time we checked (I cannot take credits for this work -- see "git show origin/todo:TODO" and look for "AsciiDoc"), AsciiDoc 8 had backward compatibility problems, and you needed to add some pragma in asciidoc.conf to make it compatible with sources written for AsciiDoc 7 (i.e. our documentation). However, the pragma is not understood by older asciidoc (and worse, makes older ones abort, as far as I recall), so we cannot just add the pragma and use either AsciiDoc 7 or 8 interchangeably.