Re: [PATCH] git-fetch: avoid local fetching from alternate (again)

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 7, 2007, 06:24 UTC
Message-ID: <7vsl3iefoj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071107024118.GA11043@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

Show 5 quoted lines

> Back in e3c6f240fd9c5bdeb33f2d47adc859f37935e2df Junio taught
> git-fetch to avoid copying objects when we are fetching from
> a repository that is already registered as an alternate object
> database.  In such a case there is no reason to copy any objects
> as we can already obtain them through the alternate.

Well spotted. It would be a good idea to commit the big comment from contrib/examples/git-fetch.sh to fetch_local_nocopy() function, which would have made us realize that the patch does not refrain from applying this optimization even when shallow is in effect. But I think that is actually a good change.

The run-command change and the main part of the fix are logically independent.

The regression the patch fixes should be testable with a script. Please have a new test for it.

Thanks.