git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: end of file newline regression

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 17, 2007, 01:24 UTC
Message-ID
<7vsl22glkk.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20071216.155413.165709543.davem@davemloft.net>
David Miller <davem@davemloft.net> writes:
Show 20 quoted lines
> I've stumbled into a problem with current mainline.
>
> I have this changeset that I can't get GIT to properly
> generate diffs for.  It always give me:
>
> diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
> index 4440532..096974b 100644
> --- a/net/ipv6/esp6.c
> +++ b/net/ipv6/esp6.c
> @@ -177,5 +177,4 @@ static int esp6_input(struct xfrm_state *x, struct sk_buff *skb)
>  			BUG();
>  
>  		if (unlikely(memcmp(esp->auth.work_icv, sum, alen))) {
> -			x->stats.integrity_failed++;
> -			ret = -EINVAL;
> \ No newline at end of file
> +			ret = -EBADMSG;
> \ No newline at end of file
>
> No matter what I do, 1.5.3.7 doesn't do this.

Sorry, there was a recent brown-paper-bag. Should have been fixed with the patches flew on the list for the past 24 hours or so. Could you try it with the tip of 'master'?

Previous: David Miller
Message 2 of 2 in “end of file newline regression”
  1. David MillerDec 16, 2007
  2. Junio C HamanoDec 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.