git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fix attribute handling in bare repositories

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 8, 2008, 20:46 UTC
Message-ID
<7vskvnirjm.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<484BF7BB.1090802@lsrfire.ath.cx>
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 7 quoted lines
> Nguyen Thai Ngoc Duy schrieb:
>> Hi,
>> 
>> Currently attr.c will read .gitattributes on disk no matter there is a
>> real worktree or not. This can lead to strange behavior.
>
> Yes, it probably shouldn't do that.  What about this patch?

Hmm. I do not know if it breaks anything, but if you are indeed in a bare repository, the files the codepaths affected try to read would not exist anyway, so I am not sure what this would fix, other than changing the behaviour of check-attr from noticing that it was asked for nonsense and bail out to not noticing nor saying anything useful.

Previous: René ScharfeNext: René Scharfe
Message 6 of 8 in “git-archive and unwanted .gitattributes”
  1. Nguyen Thai Ngoc DuyJun 7, 2008
  2. Jakub NarebskiJun 7, 2008
  3. Nguyen Thai Ngoc DuyJun 7, 2008
  4. René ScharfeJun 8, 2008
  5. fix attribute handling in bare repositoriesRené Scharfe, Jun 8, 2008
  6. Junio C HamanoJun 8, 2008
  7. René ScharfeJun 8, 2008
  8. Nguyen Thai Ngoc DuyJun 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.