Re: [PATCH v2] bash-completion: Add non-command git help files to bash-completion
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 16, 2008, 09:30 UTC
- Message-ID
- <7vskt5gvcy.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080815180059.GA17399@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 9 quoted lines
> Marcus Griep <marcus@griep.us> wrote: >> Git allows access to the gitattributes man page via `git help attributes`, >> but this is not discoverable via the bash-completion mechanism. This >> patch adds all current non-command man pages to the completion candidate >> list. >> >> Signed-off-by: Marcus Griep <marcus@griep.us> > > Acked-by: Shawn O. Pearce <spearce@spearce.org>
I'd honor this Ack for 1.6.0 and will apply the patch as-is, but that does not mean I do not think this is a wrong approach in the longer run.