Re: [PATCH] git-svn: don't escape tilde ('~') for http(s) URLs

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 22, 2008, 06:24 UTC
Message-ID: <7vskqpuoyb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081022061325.GC8225@glandium.org>

Mike Hommey <mh@glandium.org> writes:

Show 14 quoted lines

> On Tue, Oct 21, 2008 at 02:53:28PM -0700, Junio C Hamano wrote:
>
>> >> For svn we have:
>> >> write(5, "<S:update-report send-all=\"true\" xmlns:S=\"svn:\">
>> >> <S:src-path>https://sucs.org/~welshbyte/svn/backuptool/trunk</S:src-path>...
>> >>
>> >> While git-svn shows:
>> >> write(7, "<S:update-report send-all=\"true\" xmlns:S=\"svn:\">
>> >> <S:src-path>https://sucs.org/%7Ewelshbyte/svn/backuptool/trunk</S:src-path>...
>> 
>> This looks like an XML based request sequence to me (and svn is talking
>> WebDAV here, right?);
>
> XML based would be &126;, not %7E.

Read what you quoted again and realize you are agreeing with me ;-).

The former (with "~") is what svn expects, the latter (with %7E) is what git-svn incorrectly threw at the server causing problems. I am wondering the whole %xx escaping thing, which does not seem to match what svn seems to expect.

> Anyways, aren't there ready-to-use url quoting functions in perl ?

My question is not about correct "url quoting", but if using "url quoting" is correct in this context.