git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: fixes to gitweb feature check code

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 17, 2008, 10:09 UTC
Message-ID
<7vskpqzms5.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200811171028.19807.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 16 quoted lines
> Dnia poniedziałek 17. listopada 2008 07:10, Giuseppe Bilotta napisał:
>> On Mon, Nov 17, 2008 at 2:02 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>
> [...]
>> > First, you forgot the signoff, but you have addressed that already.
>> >
>> >
>> > Second, I thought at first that it would be good for the patch to also
>> > simplify %feature hash, using "'default' => 1" instead of current bit
>> > convoluted "'default' => [1]", at the cost of bit more code for
>> > defensive programming.  But now I think that if it is to be done,
>> > it should be put as separate patch.
>> 
>> Is this an ACK? 8-D
>
> I'm sorry. Yes, it is.

Are you sure, even with those unnecessary changes from list context assignments to scalar ones?

Previous: Jakub NarebskiNext: Jakub Narebski
Message 8 of 9 in “gitweb: fixes to gitweb feature check code”
  1. gitweb: fixes to gitweb feature check codeGiuseppe Bilotta, Nov 15, 2008
  2. Giuseppe BilottaNov 16, 2008
  3. Junio C HamanoNov 16, 2008
  4. Giuseppe BilottaNov 16, 2008
  5. Jakub NarebskiNov 17, 2008
  6. Giuseppe BilottaNov 17, 2008
  7. Jakub NarebskiNov 17, 2008
  8. Junio C HamanoNov 17, 2008
  9. Jakub NarebskiNov 17, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.