Re: summaries in git add --patch

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 3, 2008, 02:15 UTC
Message-ID: <7vskp6j95x.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <49308B4B.3070703@gmail.com>

William Pursell <bill.pursell@gmail.com> writes:

Show 13 quoted lines

> Junio C Hamano wrote:
>> William Pursell <bill.pursell@gmail.com> writes:
>>
>>> Here's a new patch.  Instead of displaying the summary and then
>>> the current hunk, it implements a 'goto' command.
>>
>> I take it that this is for discussion not for immediate inclusion.
>
> Yes.  I tend to think of all of my patches as being merely
> for discussion since I'm not terribly familiar with the code
> base and expect to miss many things.  I'm flattered that
> you would even consider them for inclusion.  For that matter,
> I'm flattered that you have even responded to my submissions!

Thanks. I value contributions from people who are enthused and can make a good case for the change they propose. I utter comments and sometimes even send out an alternative implementation to illustrate what might be a better approach. IOW, I try to help people make progress.

One thing I will not do after such a discussion, unless I am really really interested in having the new feature personally myself, is to go back to the discussion thread and assemble the pieces together to make the final series of patches for inclusion. The responsibility for doing that lies on the original contributor.