Re: gc considered dangerous

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 9, 2009, 07:43 UTC
Message-ID: <7vskmoukcb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090209065919.GB13257@glandium.org>

Mike Hommey <mh@glandium.org> writes:

Show 17 quoted lines

> On Sun, Feb 08, 2009 at 12:00:57PM -0800, Junio C Hamano wrote:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> 
>> > My preliminary guess is that this code in pack-write.c needs to use the 
>> > lock file paradigm:
>> >
>> >         if (!index_name) {
>> > 		[...]
>> >         } else {
>> >                 unlink(index_name);
>> >                 fd = open(index_name, O_CREAT|O_EXCL|O_WRONLY, 0600);
>> >         }
>> 
>> Whoa.  That particular code has been (and is still) correct.
>
> Don't both unlink and open fail in the case the index file is locked in
> Windows ?

Read the rest of the thread and read the code.

The index_file in question is not the file git-repack is telling pack-write.c to unlink and open.