Re: [PATCH] git-gui: Fix file name pattern in .gitattributes.

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 24, 2009, 17:33 UTC
Message-ID: <7vskm3hh8n.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <49A3BD25.3000706@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

Show 30 quoted lines

> Junio C Hamano schrieb:
>> Johannes Sixt <j6t@kdbg.org> writes:
>> 
>>> The pattern for the *.po files was anchored at the repository's root, but
>>> this would match the files only in the git-gui repository itself, but
>>> not in the version that is subtree-merged into git.git.
>>>
>>> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
>>> ---
>>>  .gitattributes |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/.gitattributes b/.gitattributes
>>> index f96112d..c69f4a0 100644
>>> --- a/.gitattributes
>>> +++ b/.gitattributes
>>> @@ -1,3 +1,3 @@
>>>  *           encoding=US-ASCII
>>>  git-gui.sh  encoding=UTF-8
>>> -/po/*.po    encoding=UTF-8
>>> +po/*.po     encoding=UTF-8
>> 
>> Hmm, really?
>
> No, not really. =:{
>
> I observed some strangeness with gitk. But it turned out that this was an
> old development version that got accidentally installed somewhere in $PATH.
>
> Sorry for the noise.

Actually, while I was responding to your message, I looked at gitattributes documentation and noticed that it does not say anything about how the "glob" is used to match paths. The rules applied should be the same as those from gitignore (except obviously we do not have negated pattern that gitignore has, because it does not mean "path not matching this pattern" over there), and it should be documented.