Re: [PATCH v2] git-cvsimport: add support for cvs pserver password scrambling.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2009, 07:25 UTC
Message-ID: <7vskfusvpq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1250233111-19188-1-git-send-email-dirker@gmail.com>

Dirk Hoerner <dirker@gmail.com> writes:

Show 5 quoted lines

> Instead of a cleartext password, the CVS pserver expects a scrambled one
> in the authentication request. With this patch it is possible to import
> CVS repositories only accessible via pserver and user/password.
>
> Signed-off-by: Dirk Hoerner <dirker@gmail.com>

Thanks.

While I appreciate your effort to add a test, I'd rather not apply the test part of your patch for two reasons:

 - It is not a test against a real cvs pserver but is a whitebox test to
   verify that the program says what the program is supposed to spit out
   to the network; and

 - It still is a network test that will fail if the TCP port is occupied
   for whatever reason when the test is run, which will make automated
   build and test cycle unreliable.

Unfortunately, I do not see an easy way to run a real cvs pserver listening to a local unix domain socket under $TRASH_DIRECTORY, which would solve both of the above issues.