git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFH] lifetime rule for url parameter to transport_get()?

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 23, 2011, 16:50 UTC
Message-ID
<7vsjosrs0w.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7vipppt175.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> Does anybody remember why we use a copied string of "ref_git_copy" in
> builtin/clone.c::setup_reference()?
>
> 	ref_git = real_path(option_reference);
> 	...
> 	ref_git_copy = xstrdup(ref_git);
It didn't have anything to do with transport/remote layer.

This codepath uses real_path() and optionally mkpath(), both of which returns a short-lived static buffer to return its findings, and long-term users are expected to copy it away.

I'll add a comment to that effect in the code.
Previous: Junio C HamanoNext: Daniel Barkalow
Message 2 of 3 in “[RFH] lifetime rule for url parameter to transport_get()?”
  1. Junio C HamanoAug 23, 2011
  2. Junio C HamanoAug 23, 2011
  3. Daniel BarkalowAug 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.