Re: [PATCH] log: allow to specify diff pathspec in addition to prune pathspec

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 4, 2011, 22:07 UTC
Message-ID: <7vsjm3a6dc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1320322556-32675-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> This form requires specifying "--" twice. If a file name happens to be
> "--", it may be misunderstood as the second "--" marker. This is an
> unfortunate consequence for this syntax. Users can still use "./--" or
> similar to workaround this.

This is not a new "problem" (and it is probably not a problem to begin with). If you had "--" in the working tree and you wanted to treat it as a path, you said either one of these:

    $ git log HEAD ./--
    $ git log HEAD -- --

The latter is what your patch breaks, I suspect.

Also it forces existing scripts and programs that knew "everything in this array is a pathspec" and added "--" before adding the contents of the array to form a command line to drive "git log" family of commands to be updated.