Re: [PATCH 1/2] drop length limitations on gecos-derived names and emails
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 15, 2012, 18:10 UTC
- Message-ID
- <7vsjf1e2n7.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120515174724.GA329@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> So it seems to me like a much simpler set of rules would be: > > 1. When reading gecos, always fall back to the username if the gecos > field is unavailable or blank. > > 2. Always die when the name field is blank. That means we will die > when you pass in a bogus empty GIT_COMMITTER_NAME (or an empty > config name), which makes a lot more sense to me than falling back; > those are bogus requests, not system config problems. And we won't > ever have a blank gecos name, because we'll always fall back on the > username.
That certainly sounds very simple to explain and understand, and I do not offhand think of anything *sane* that would break ;-)
Thanks.