Re: [PATCH v3] diff-no-index: exit(1) if 'diff --quiet <repo file> <external file>' finds changes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 21, 2012, 16:55 UTC
- Message-ID
- <7vsjdosiz3.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAFouethNTzcWq_YKzGz+jRTeCjKZEC2ZYMZuQxkF+5AOTC=x-A@mail.gmail.com>
Tim Henigan <tim.henigan@gmail.com> writes:
> It looks like the best place to add tests is t4010-diff-pathspec.sh.
Well, pathspecs are all about limiting the changes in the repository by patterns, while "diff --no-index" is about exact pathnames, so I am not sure if that is a good place to put them. Isn't there a test script that is dedicated to the "diff --no-index" codepath (perhaps 4053) that is more appropriate for doing this?