Re: [PATCH v2] Support non-WIN32 system lacking poll() while keeping the WIN32 part intact

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2012, 16:07 UTC
Message-ID: <7vsjbc1dg1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <004001cd81f9$21e68e10$65b3aa30$@schmitz-digital.de>

"Joachim Schmitz" <jojo@schmitz-digital.de> writes:

Show 14 quoted lines

> There is a downside with this: In order to make use of it, in Makefile it 
> adds "-Icompat/win32" to COMPAR_CFLAGS. This results in 
> compat/win32/dirent.h to be found, rather than /usr/include/dirent.h. 
> This should be fine for WIN32, but for everybody else may not. 
> For HP NonStop in particular it results in a warning:
>
>         };
>          ^
> "... /compat/win32/dirent.h", line 17: warning(133): expected an identifier
>
> And this is because there it uses an unnamed union, which is a GCC extension 
> (just like unnamed struct), but not part of C89/C99/POSIX.
>
> One possible solution might be to move compat/win32/poll.[ch] to compat/.

I think that is the most sensible way to go, because poll.[ch]

 (1) has proven itself to be useful outside the context of win32, and
 (2) the code is coming from gnulib anyway.

I thought I already suggested going that route in my previous review, but perhaps I forgot to do so.