Re: [PATCH] Racy GIT

From: Junio C Hamano <junkio@cox.net>
Date: Dec 20, 2005, 19:28 UTC
Message-ID: <7vr787h8ku.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vwti0go2w.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

> This fixes the longstanding "Racy GIT" problem,...

Sorry, it does not really.

Show 5 quoted lines

> If you run the following sequence of commands:
>
>         echo frotz >infocom
>         git update-index --add infocom
>         echo xyzzy >infocom

The patch deals with the above sequence correctly, but it breaks down with:

	echo frotz >infocom
        git update-index --add infocom
        echo xyzzy >infocom
        sleep 3 ;# a little while later
        echo nitfol >activision
        git update-index --add activision
        git diff-files infocom

We need to detect the false clean entries just before we write out index in the second update-index and mark them out of date.