Re: [PATCH] git-ls-files: Fix, document, and add test for --error-unmatch option.

From: Junio C Hamano <junkio@cox.net>
Date: Feb 22, 2006, 01:59 UTC
Message-ID: <7vr75wtapo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <87vev8sajl.wl%cworth@cworth.org>

Carl Worth <cworth@cworth.org> writes:

>  I'm still not sure what the easiest way is for me to provide changes
>  to you. I've been doing it here on the list, like with the current
>  message. But would it be easier for me to send pull requests?

You can decide what is easier for _you_ ;-).

But for me, emailed patches are easier to work on than pull requests. I will need to read and understand most of the changes anyway, unless the change is to an isolated corner of the system that would affect only one class of users and breakage will be noticed either immediately or can be left broken if nobody uses that (e.g. things like contrib/ and some foreign SCM interfaces). I would like others on the list to be able to review the same changes that might hit my tree and provide extra sets of eyeballs to spot things I might miss myself alone.

>  For example, with the git-clone failure cleanup I recently did, it
>  seems the new test case I wrote didn't land in your tree.

Sorry, I think I just forgot to apply that one. I still have the message so no need to resend. Thanks for reminding.