Re: [PATCH] commit encoding: store it in commit header rather than mucking with NUL

From: Junio C Hamano <junkio@cox.net>
Date: Dec 25, 2006, 07:27 UTC
Message-ID: <7vr6uoo2ow.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0612250134040.19693@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 7 quoted lines

>>  - I was not sure if the "assume the whole commit->buffer is in
>>    the local encoding and recode it into UTF-8" is correct.
>
> For the purpose of showing it, there is no point in using two different 
> encodings. I am not aware of any terminal (and do not own such a terminal 
> anyway) which can display text with parts encoded differently from the 
> rest.

That's not what I meant. Because the definition of the contents of the commit has been (and will be --- the unpublished topic was about suggesting stronger convention across Porcelains) just the set of fixed headers plus binary blob, the use of different encodings is entirely up to the users.

I was afraid that there might be something we did (or we did not do) that encouraged people to have their names (via environment variables, or perhaps user.name) always in UTF-8 while recording the log messages in the legacy encoding, and if that kind of use is already done in the wild, we would end up having to not reencode the header field but reencode the body.

But I do not think we ever encouraged encoding names in UTF-8 or
anything else (we did encourage use of UTF-8 in the commit log),
so I think we are Ok.