Re: [RFC] git-svn: make git-svn commit-diff able to work without explicit arguments

From: Junio C Hamano <junkio@cox.net>
Date: Jan 2, 2007, 20:30 UTC
Message-ID: <7vr6udtbmv.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <459AA31E.5070705@gmail.com>

Steve Frécinaux <nudrema@gmail.com> writes:

Show 5 quoted lines

> When using git-svn to access a SVN repo, the commit policy may
> vary. While git makes you commit small patches often, svn users tend
> to prefer bigger patches that implement a functionnality at once.
>
> So at the end you have a SVN commit which corresponds to several git ones.

I personally think this is solving a wrong problem. Commit granularity is a property of the project, the way in which people involved in the project prefer working. It is not about "svn users" vs "git users", and it shouldn't be, especially if the end result is still a single project.

Is git "making you commit small patches often"? I honestly hope we are not forcing you to do so, although we took pains to make it easier because it tends to be easier to look at the history later when commit boundaries match the logical steps of evolution.

So my suggestion would be to educate people who tend to make too large commits better separate their commits, and at the same time coallesce the commits you create on the git side into a presentable size, if you acquired a bad habit of making too small commits, so that everybody follows the same commit granularity guideline set by the project.