git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff --check: use colour

From
Junio C Hamano <junkio@cox.net>
Date
Jan 24, 2007, 23:18 UTC
Message-ID
<7vr6tkdnee.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.63.0701241505260.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Reuse the colour handling of the regular diff.
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 7 quoted lines
> Reuse the colour handling of the regular diff.
>
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
>
> 	Is it possible that diff_get_color() _never_ returns NULL?
> 	Then diff.c can be further cleaned up...

Does anybody actually use "diff --check"? We could lose more code by removing the option altogether ;-)

Seriously, this option needs to be documented.  Volunteers?
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 2 of 26 in “diff --check: use colour”
  1. diff --check: use colourJohannes Schindelin, Jan 24, 2007
  2. Junio C HamanoJan 24, 2007
  3. Johannes SchindelinJan 25, 2007
  4. Junio C HamanoJan 25, 2007
  5. Bill LearJan 25, 2007
  6. Johannes SchindelinJan 25, 2007
  7. Bill LearJan 26, 2007
  8. Jeff KingJan 26, 2007
  9. Andreas EricssonJan 26, 2007
  10. Andy ParkinsJan 26, 2007
  11. Bill LearJan 26, 2007
  12. Bill LearJan 26, 2007
  13. J. Bruce FieldsJan 26, 2007
  14. Bill LearJan 26, 2007
  15. Bill LearJan 26, 2007
  16. Jeff KingJan 26, 2007
  17. Jakub NarebskiJan 26, 2007
  18. Andy ParkinsJan 26, 2007
  19. Jakub NarebskiJan 26, 2007
  20. Junio C HamanoJan 26, 2007
  21. Johannes SchindelinJan 26, 2007
  22. Junio C HamanoFeb 18, 2007
  23. Johannes SchindelinFeb 18, 2007
  24. Junio C HamanoFeb 18, 2007
  25. Johannes SchindelinFeb 18, 2007
  26. diff --check: use colourJohannes Schindelin, Feb 18, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.