git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/13] declare overflow during base128 decoding when 1 MSB nonzero, not 7

From
Junio C Hamano <junkio@cox.net>
Date
Apr 5, 2007, 22:51 UTC
Message-ID
<7vr6qymo3r.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<56b7f5510704051524p28eafc18mae3131ef13cdabfa@mail.gmail.com>
"Dana How" <danahow@gmail.com> writes:
Show 22 quoted lines
> Subject: [PATCH 02/13] declare overflow during base128 decoding when 1 MSB nonzero, not 7
>
> ---
>  builtin-pack-objects.c   |    2 +-
>  builtin-unpack-objects.c |    2 +-
>  index-pack.c             |    2 +-
>  sha1_file.c              |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
> index b5f9648..50246e1 100644
> --- a/builtin-pack-objects.c
> +++ b/builtin-pack-objects.c
> @@ -1014,7 +1014,7 @@ static void check_object(struct object_entry *entry)
>  				ofs = c & 127;
>  				while (c & 128) {
>  					ofs += 1;
> -					if (!ofs || ofs & ~(~0UL >> 7))
> +					if (!ofs || ofs & ~(~0UL >> 1))
>  						die("delta base offset overflow in pack for %s",
>  						    sha1_to_hex(entry->sha1));
>  					c = buf[used_0++];
The line after these context does this:
	ofs = (ofs << 7) + (c & 127);
If you do not check the top 7 bits, wouldn't you miss overflow?
Previous: Dana HowNext: Dana How
Message 2 of 6 in “declare overflow during base128 decoding when 1 MSB nonzero, not 7”
  1. 02/13 declare overflow during base128 decoding when 1 MSB nonzero, not 7Dana How, Apr 5, 2007
  2. Junio C HamanoApr 5, 2007
  3. Dana HowApr 5, 2007
  4. Junio C HamanoApr 6, 2007
  5. Nicolas PitreApr 6, 2007
  6. Nicolas PitreApr 6, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.