git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix git-clone buglet for remote case.

From
Junio C Hamano <junkio@cox.net>
Date
May 14, 2007, 21:25 UTC
Message-ID
<7vr6pjm71b.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.64.0705141836350.26948@jalava.cc.jyu.fi>

c2f599e09fd0496413d1744b5b89b9b5c223555d introduced a buglet while cloning from a remote URL; we forgot to squelch the unnecessary error message when we try to cd to the given "remote" name, in order to see if it is a local directory.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
Tero Roponen <teanropo@jyu.fi> writes:
  > the latest git seems to output a warning every time I
  > try to clone a repository that is not local:
  >
  > $ git --version
  > git version 1.5.2.rc3.27.g43d151
  >
  > $ git clone git://git.kernel.org/pub/scm/git/git.git
  > /usr/local/bin/git-clone: line 23: cd: git://git.kernel.org/pub/scm/git/git.git: No such file or directory
  Yup, thankfully that is harmless but it is ugly and wrong
  nevertheless.  Thanks for the report.
 git-clone.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-clone.sh b/git-clone.sh
index 70374aa..fdd354f 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -22,10 +22,10 @@ get_repo_base() {
 		cd "`/bin/pwd`" &&
 		cd "$1" &&
 		{
-			cd .git 2>/dev/null
+			cd .git
 			pwd
 		}
-	)
+	) 2>/dev/null
 }
 
 if [ -n "$GIT_SSL_NO_VERIFY" ]; then
-- 
1.5.2.rc3.27.g43d151
Previous: Tero Roponen
Message 2 of 2 in “git-clone tries to cd to a remote repository”
  1. Tero RoponenMay 14, 2007
  2. Fix git-clone buglet for remote case.Junio C Hamano, May 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.