Re: [RFC][PATCH 10/10] Sparse: fix a "symbol 'weak_match' shadows an earlier one" warning

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 9, 2007, 08:07 UTC
Message-ID: <7vr6olh7pb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <4669D7BC.3060607@ramsay1.demon.co.uk>

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

Show 17 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>  connect.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/connect.c b/connect.c
> index da89c9c..d4051dd 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -179,7 +179,6 @@ static int count_refspec_match(const char *pattern,
>  	for (weak_match = match = 0; refs; refs = refs->next) {
>  		char *name = refs->name;
>  		int namelen = strlen(name);
> -		int weak_match;
>  
>  		if (namelen < patlen ||
>  		    memcmp(name + namelen - patlen, pattern, patlen))

This one is an obvious bug. Essentially, it makes weak matches ignored. Unfortunately this has been hiding a larger bug in the caller of this function. I am refactoring the mess right now.