Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present
Greg KH <greg@kroah.com> writes:
Show 6 quoted lines
> When using git-send-email.perl on a changeset that has:
> Cc: <stable@kernel.org>
> in the body of the description, and the Email::Valid perl module is
> installed on the system, the email address will be deemed "invalid" for
> some reason (Email::Valid isn't smart enough to handle this?) and
> complain and not send the address the email.
That appears to be the case.
bad foo
bad <foo@bar.baz>
ok foo@bar.baz
ok Foo <foo@bar.baz>> Anyway, this tiny patch fixes this problem for me. Note, my perl-foo is
> quite week, so this could probably be easily done in one line for those
> with better reg-ex skills.
Show 11 quoted lines
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -410,6 +410,9 @@ sub extract_valid_address {
> return $address if ($address =~ /^($local_part_regexp)$/);
>
> if ($have_email_valid) {
> + if ($address =~ s/^<//) {
> + $address =~ s/>$//;
> + }
> return scalar Email::Valid->address($address);
> } else {I'd probably do:
if ($have_email_valid) {
$address =~ s/^<(.*)>$/$1/;
return scalar Email::Valid->address($address);
} else {instead, but they are moral equivalents.
Thanks for a fix.
Junio C Hamano <gitster@pobox.com>